Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version on crates.io (0.3.0) does not support openssl 1.1.1 #245

Closed
futile opened this issue Sep 22, 2018 · 6 comments
Closed

Version on crates.io (0.3.0) does not support openssl 1.1.1 #245

futile opened this issue Sep 22, 2018 · 6 comments

Comments

@futile
Copy link

futile commented Sep 22, 2018

Running cargo install cargo-edit resulted in an "unknown openssl version" error reported by the rust-openssl crate, which was built as version 0.9.x. My system-installed openssl is 1.1.1, and it seems rust-openssl 0.9.x can't detect that.

The recent update of reqwest seems to already have bumped the dependency up on master, and cloning the current master and running cargo install --path . worked fine.

So probably doing a new release to crates.io would be a good idea.

@killercup
Copy link
Owner

Thanks for the report!

@ordian, I saw you merged some PRs just now. Do you have time to bump request (and other crates if useful) and make a release?

@ordian
Copy link
Collaborator

ordian commented Sep 24, 2018

Hey Pascal! Was planning to, but I'm on a bad wifi right now (and for the rest of the week), so you might as well do it yourself ;) The reqwest is bumped already btw.

@killercup
Copy link
Owner

killercup commented Sep 24, 2018 via email

bors bot added a commit that referenced this issue Sep 24, 2018
246: Release 0.3.1 r=killercup a=killercup

Closes #245

Co-authored-by: Pascal Hertleif <killercup@gmail.com>
bors bot added a commit that referenced this issue Sep 24, 2018
246: Release 0.3.1 r=killercup a=killercup

Closes #245

Co-authored-by: Pascal Hertleif <killercup@gmail.com>
bors bot added a commit that referenced this issue Sep 25, 2018
246: Release 0.3.1 r=killercup a=killercup

Closes #245

Co-authored-by: Pascal Hertleif <killercup@gmail.com>
@bors bors bot closed this as completed in #246 Sep 25, 2018
@killercup
Copy link
Owner

Published: https://crates.io/crates/cargo-edit/0.3.1

@futile
Copy link
Author

futile commented Sep 25, 2018

$ cargo install --force cargo-edit
    Updating crates.io index
 Downloading cargo-edit v0.3.1
  Installing cargo-edit v0.3.1
 Downloading reqwest v0.9.1
   [...]
   Compiling cargo-edit v0.3.1
    Finished release [optimized] target(s) in 2m 21s
   Replacing <$HOME>/.cargo/bin/cargo-add
   Replacing <$HOME>/.cargo/bin/cargo-rm
   Replacing <$HOME>/.cargo/bin/cargo-upgrade

Can confirm it works! 👍

@killercup
Copy link
Owner

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants