Email validation for managed members should only fail if it does not match the domain set to a broker #29461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match the domain set to a broker Closes keycloak#29460 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
keycloak-github-bot
bot
added
team/cloud-native
team/core-clients
team/core-iam
flaky-test
labels
This was referenced May 11, 2024
Closed
Closed
|
LGTM. Lots of database transactions for each validation but I'm not sure that's avoidable; can also be addressed if there's an issue rather than trying to optimize for that immediately |
sguilhen
reviewed
May 13, 2024
services/src/main/java/org/keycloak/organization/validator/OrganizationMemberValidator.java
Show resolved
Hide resolved
@alice-wondered Wouldn't be addressed by caching? Or do you think we can improve the logic a bit to avoid any unnecessary call? |
sguilhen
approved these changes
May 13, 2024
Yeah I think caching will account for the main concern I have for sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29460