Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus-next: keystore/trust store type is determined based on file extension #29207

Open
Pepo48 opened this issue May 2, 2024 · 1 comment · Fixed by #29373
Open

quarkus-next: keystore/trust store type is determined based on file extension #29207

Pepo48 opened this issue May 2, 2024 · 1 comment · Fixed by #29373
Assignees
@Pepo48
Labels
area/dist/quarkus kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon team/cloud-native

Comments

@Pepo48
Copy link
Contributor

Pepo48 commented May 2, 2024

Description

Keycloak should be aligned with the most recent Quarkus changes in this area:

In 3.9, JKS is no longer the default keystore and trust store format. Quarkus makes an educated guess based on the file extension:

  • .pem, .crt and .key are read as PEM certificates and keys
  • .jks, .keystore and .truststore are read as JKS key stores and trust stores
  • .p12, .pkcs12 and .pfx are read as PKCS12 key stores and trust stores
    If your file does not use one of these extensions, you need to set the format using:
    quarkus.http.ssl.certificate.key-store-file-type=JKS # or P12 or PEM
    quarkus.http.ssl.certificate.trust-store-file-type=JKS # or P12 or PEM

Source: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.9#keystore-and-trust-store-default-format-change

This change causes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode to fail. The problems were first spotted in the quarkus-next branch.
@Pepo48 Pepo48 self-assigned this May 2, 2024
@keycloak-github-bot
Copy link

Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment.

If you are affected by this issue, upvote it by adding a 👍 to the description. We would also welcome a contribution to fix the issue.

Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 8, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
b570968 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48 Pepo48 mentioned this issue May 8, 2024
Merged
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 16, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
aa72c1c 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 22, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
1626c1d 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 22, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
9a3f3f3 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
4e78d7e 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
883214c 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
0da9212 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
9758ce4 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
0dd1869 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48 added a commit to Pepo48/keycloak that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
4b1e616 
…xtension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: keycloak#29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
vmuzikar pushed a commit that referenced this issue May 23, 2024
@Pepo48
quarkus-next: keystore/trust store type is determined based on file e…
b5b2bbf 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions bot pushed a commit that referenced this issue May 24, 2024
@Pepo48 @github-actions
quarkus-next: keystore/trust store type is determined based on file e…
0186c0d 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions bot pushed a commit that referenced this issue May 25, 2024
@Pepo48 @github-actions
quarkus-next: keystore/trust store type is determined based on file e…
d01c1e1 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions bot pushed a commit that referenced this issue May 26, 2024
@Pepo48 @github-actions
quarkus-next: keystore/trust store type is determined based on file e…
2989648 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions bot pushed a commit that referenced this issue May 27, 2024
@Pepo48 @github-actions
quarkus-next: keystore/trust store type is determined based on file e…
d8d0c4f 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions bot pushed a commit that referenced this issue May 28, 2024
@Pepo48 @github-actions
quarkus-next: keystore/trust store type is determined based on file e…
48572b8 
…xtension (#29373)

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

* quarkus-next: keystore/trust store type is determined based on file extension

* fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode

Closes: #29207

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

---------

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pepo48 Pepo48

Labels
area/dist/quarkus kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quarkus-next: keystore/trust store type is determined based on file extension Pepo48/keycloak
2 participants
@Pepo48 @vmuzikar