Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display multiple keys pressed within 1 popup (for eg. in Figma Command + Space + K is for creating components) #290

Open
holovashkin opened this issue Jan 30, 2024 · 3 comments

Comments

@holovashkin
Copy link

First of all, I'd like to say THANK YOU to everyone contributed to this App. Guys, you're amazing! I've been looking for something like that for long (but never had enough time to research like I did now)

It's not a bug but rather idea/suggestion and I'd implement on my own but I'm not that good with coding unfortunately 🥲.

Currently it displays as if separate keys pressed
Screenshot 2024-01-30 at 16 53 47

I assume, the working solution could be:

  • setting a delay, after which if no keys were pressed - multiple merged hotkeys are displayed
  • a little more complex but UX friendly: display immediately, but live update the additional keys pressed
  • to keep regular users who don't need this happy - enable this feature only if checkbox in settings is checked

Also might be worth keeping in mind or even going this specific logic (which may apply to most of the other cases):

  • if a button is pressed and remains pressed: the next keys are added to this specific popup

and lastly, not related to the issue itself, but the App is so good I'd pay for it or donate / help in other way if I can be of any use

Thanks again and feel free to clarify any details ❤️❤️❤️

@holovashkin
Copy link
Author

Also another thing I missed (but might be too much unrelated to the APP) - is displaying both Mac and Windows shortcuts.
The use case would be Figma - during the stream, students who use windows would see shortcut for their OS. (I assume it's not possible and wouldn't work without extra modifications specifically for such purpose)

In case if this also gets added to future scope - the MVP could be either showing 2 shortkeys per OS left and right sides, disabled by default and enabled as a checkbox feature in the settings

@holovashkin
Copy link
Author

Small update: pardon, just discovered alternative Svelte visualizer - so it seams the functionality is already available 😅
(However, I'd still prefer using default visualizer with multiple key combination in single popup)

@akitchen
Copy link
Member

akitchen commented Feb 3, 2024

Thank you for opening an issue, yes as you've discovered the Default vs Svelte visualizer sort of covers this use case but not entirely. What you're asking for in the behavior of multiple keypresses is likely a candidate for a different visualizer, which could be developed (the app supports it) but is probably not something I'd be working on any time soon.

The default visualizer has some user-tunable parameters for delay (line break delay) which isn't exactly what you're asking for, but you could tune it to get nearly the same effect. But a command entry (with cmd or ctrl key) is a command sequence and will always incur a line break. If you want to change that, you'll need to develop a more customizable visualizer plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants