Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubbot: preview links with issues/PR from private repos and secret gist #242

Open
powerman opened this issue May 14, 2020 · 3 comments
Open

Comments

@powerman
Copy link

powerman commented May 14, 2020

It would be very useful to implement this feature. I suppose this means bot must run unrestricted to be able to read links in all messages. 馃槥 Maybe there is a way to let bot read only messages which begins with https://github.com/ and https://gist.github.com/ substrings?

@powerman powerman changed the title Preview links with issues/PR from private repos and secret gist github: preview links with issues/PR from private repos and secret gist May 14, 2020
@powerman powerman changed the title github: preview links with issues/PR from private repos and secret gist githubbot: preview links with issues/PR from private repos and secret gist May 14, 2020
@joshblum
Copy link
Member

We could expose a !github show <url> command (jirabot does this) or if you just @-mention the bot it can scan the message for URLs to preview. cc @hyperobject

@powerman
Copy link
Author

@-mention sounds more convenient.

BTW, I'm surprised to get an answer so fast - I was thinking you guys will have no time to work on keybase at all in next several months at least (because of Zoom). It's nice to see keybase isn't abandoned.

@cori-hudson
Copy link
Contributor

We could expose a !github show <url> command (jirabot does this) or if you just @-mention the bot it can scan the message for URLs to preview. cc @hyperobject

yeah this would probably be pretty doable! would need to make sure that the github app already has the permissions we need to preview links, but i think we do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@joshblum @powerman @cori-hudson and others