Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for streams #156

Open
CaptnH00k opened this issue Jul 5, 2017 · 10 comments
Open

Support for streams #156

CaptnH00k opened this issue Jul 5, 2017 · 10 comments

Comments

@CaptnH00k
Copy link

In your documentation you mention, that streams will be supported in the future ("For arbitrarily large files, streams will come soon in kbpgp's future."). Any ETA/progress/anything on this?

@CaptnH00k CaptnH00k changed the title Support of file streams Support for streams Jul 5, 2017
@maxtaco
Copy link
Contributor

maxtaco commented Jul 5, 2017

IT turned out to be insanely complicated, and soured us on PGP

@kellym
Copy link

kellym commented Jul 5, 2017

I've been looking in the past for a way and just revisited this topic about an hour ago. There's definitely a need for stream support. Any (even brief) feedback on complexities or hurdles, or advice to abandon ship on writing it? I need to find a way to use streams to implement it since we have to do it on some huge files, but I'd love to not go down a rabbit hole if at all possible.

@kellym
Copy link

kellym commented Jul 5, 2017

Nevermind. Found a fork of openpgpjs that supports streams and I see what you mean :). Well, I've got somewhere to start from at least.

@maxtaco
Copy link
Contributor

maxtaco commented Jul 5, 2017

I recommend saltpack instead.

@CaptnH00k
Copy link
Author

CaptnH00k commented Jul 6, 2017

I feared this answer, but it seems to be the same reason why openpgpjs didn't implement it yet.
Still @kellym, which fork did you find that supports streams? Only know there was a pr for openpgpjs which kinda implemented it, but only for encryption if i remember it correctly. PR was this one: openpgpjs/openpgpjs#321

Thanks for the saltpack recommendation, looks promising, but sadly no javascript.

@maxtaco
Copy link
Contributor

maxtaco commented Jul 6, 2017

We have a js implementation. Cc @oconnor663

@maxtaco
Copy link
Contributor

maxtaco commented Jul 6, 2017

The problem you are going to hit with steaming is that you have to create new sub streams in flight. For instance you decrypt, and you say oh shit, I have to start inflating now because there is a zlib stream inside the encrypted stream. It is an utter mess.

@kellym
Copy link

kellym commented Jul 6, 2017

@CaptnH00k Yes, that openpgpjs PR was the one I had initially seen.

@maxtaco Ah, I haven't done enough digging in to come across that issue, that's a great point. We may end up having to create a custom solution then, since we only require encryption.

@kellym
Copy link

kellym commented Jul 27, 2017

FYI @CaptnH00k, I opened a PR openpgpjs/openpgpjs#567 that hopefully improves upon the existing streaming versions out there. It's still incomplete, but more complete than the alternatives.

Wish I could've done it for kbpgp instead, but I was deterred by the use of IcedCoffeeScript... I've been using CoffeeScript for what feels like ages but didn't feel like adopting ICS when everything else is moving to straight ES6.

@HR
Copy link

HR commented Mar 7, 2020

As of 2020, any plans to still add support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants