Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash styling bug #31

Open
xpepermint opened this issue Feb 7, 2015 · 1 comment
Open

Hash styling bug #31

xpepermint opened this issue Feb 7, 2015 · 1 comment

Comments

@xpepermint
Copy link

I started the descusion here. In the example bellow the if:, unless:, presente: should be colored differently (now with the same color).

class Product < ActiveRecord::Base
  belongs_to :project

  enum status: { enabled: 1, disabled: 2 }

  validates :project, :type, presence: true
  with_options if: :something?, unless: :something? do |step|
    step.validates :name, :description, presence: true
  end
end

Can we add this?

@svanharmelen
Copy link
Collaborator

@xpepermint looking at the discussion your referenced, I wonder if this should indeed be done. It's a simple change, but for example when checking this is Sublime I see it also (wrongly) highlights only the keywords if: and unless:.

By adding a dedicated color for symbol.haskey somthing like this could be achieved:

image

But before adding that I would like to know is that is actually expected and desired behaviour? And I now used the pink/red color, but maybe it should have the orange color instead? Don't know how other Monokai themes color this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants