Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax color is broken since Atom 1.32.0 due to Tree-Sitter integration #101

Open
mdouchement opened this issue Oct 24, 2018 · 5 comments
Open

Comments

@mdouchement
Copy link

mdouchement commented Oct 24, 2018

Tree-Sitter is the brand new syntax parser of Atom
http://blog.atom.io/2018/10/23/atom-1-32.html

NB: Lot of syntax-themes from the community are broken too.
https://github.com/atom/atom/issues?q=is%3Aissue+is%3Aopen+label%3Atree-sitter

(left: Atom 1.31.2 - right: Atom 1.32.0)
vs1
vs2

@Dominik1799
Copy link

Did you find any solution to that problem? Is there any way to fix it?

@mdouchement
Copy link
Author

Nope I didn't find any solution.
Regenerating the theme does not change anything.

curl -LO http://www.monokai.nl/blog/wp-content/asdev/Monokai.tmTheme
apm init --theme monokai32 --convert Monokai.tmTheme
cd monokai32
apm link

I'm wondering if it is not a bug in https://github.com/atom/language-go

@mdouchement
Copy link
Author

As a workaround, it's possible to disable Tree-Sitter and restore the old behavior.
Uncheck the option Settings => Core => Use Tree Sitter Parsers

@mdouchement
Copy link
Author

It's an Atom issue. Some improvements have been added in https://github.com/atom/atom/releases/tag/v1.32.1

@gsmetal
Copy link

gsmetal commented Nov 29, 2018

It's not a bug in Atom since v1.32.1. They've added (atom/language-ruby#244 for example) much more scopes in tree-sitter parser, which are simply not used in this theme. It should be updated to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants