Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Telescope #9

Open
Shatur opened this issue Mar 27, 2021 · 10 comments
Open

Support for Telescope #9

Shatur opened this issue Mar 27, 2021 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@Shatur
Copy link

Shatur commented Mar 27, 2021

Is your feature request related to a problem?
You mentioned that Preview with fzf needs a pipe command, Windows can't be supported.. But there is an awesome telescope.nvim that works fast and allows to avoid using external program. It would be nice to support it :)

Describe the solution you'd like
It would be nice to have an option to use Telescope instead of FZF.

@kevinhwang91
Copy link
Owner

Every fuzzy find can import the data of the current quickfix and become a filter for quickfix. But for now, only the UI of fzf perfectly compatible with quickfix.

If you want to filter data for quickfix, I think you can do it in telescope.nvim.

@kevinhwang91 kevinhwang91 added the help wanted Extra attention is needed label Mar 27, 2021
@kevinhwang91
Copy link
Owner

You mentioned that Preview with fzf needs a pipe command, Windows can't be supported.. But there is an awesome telescope.nvim that works fast and allows to avoid using external program. It would be nice to support it :)

I am not sure if you are still using bqf, but preview with fzf has been supported for Windows since 50dae9a.

@dagadbm
Copy link

dagadbm commented Jul 21, 2022

nvim community is all moving to telescope so

@kevinhwang91
Copy link
Owner

nvim community is all moving to telescope so

so PR is welcome

@defr0std
Copy link

defr0std commented May 6, 2023

Telescope already supports quickfix filtering, so not sure if anything is actually needs to be done here.

The workflow is this:

  • Get your data into a quickfix
  • Run :Telescope quickfix, this will open the telescope with the current quickfix contents.
  • Filter data as needed in Telescope UI.
  • Send the results from Telescope back into the quickfix, default action is <C-q>.

Voila, now the quickfix is filtered.

@Shatur
Copy link
Author

Shatur commented May 6, 2023

Telescope already supports quickfix filtering

The issue is it uses fuzzy finding which is not always desirable.

@defr0std
Copy link

defr0std commented May 6, 2023

Describe the solution you'd like
It would be nice to have an option to use Telescope instead of FZF.

Then maybe I did not understand what this issue is about. It says:

Describe the solution you'd like
It would be nice to have an option to use Telescope instead of FZF.

Isn't FZF a fuzzy finder by definition? :)

@Shatur
Copy link
Author

Shatur commented May 6, 2023

Oh, sorry, I thought that it's a different issue :)

The workflow is good, but bqf provides more.
Fzf integration for Neovim also have quickfix picker.

@przepompownia
Copy link

Currently no nvim-bqf change (more: no nvim-bqf) is needed to filter quickfix list using Telescope. Try :Telescope quickfix or create a keymap like below (possibly with pcall on require):

local function configureWindow()
 --- other settings
  vim.keymap.set({'n'}, 'zf', require('telescope.builtin').quickfix, {buffer = true})
end

local augroup = vim.api.nvim_create_augroup ('BqfMappings', {clear = true })
vim.api.nvim_create_autocmd ('FileType', {
  group = augroup,
  pattern = 'qf',
  callback = configureWindow,
})

Conversely, on the Telescope side we can create the new quickfix list (<C-q> by default, run <C-/> for help).

@kevinhwang91 it would be good to add such hint to README.

@kevinhwang91
Copy link
Owner

Currently no nvim-bqf change (more: no nvim-bqf) is needed to filter quickfix list using Telescope. Try :Telescope quickfix or create a keymap like below (possibly with pcall on require):

local function configureWindow()
 --- other settings
  vim.keymap.set({'n'}, 'zf', require('telescope.builtin').quickfix, {buffer = true})
end

local augroup = vim.api.nvim_create_augroup ('BqfMappings', {clear = true })
vim.api.nvim_create_autocmd ('FileType', {
  group = augroup,
  pattern = 'qf',
  callback = configureWindow,
})

Conversely, on the Telescope side we can create the new quickfix list (<C-q> by default, run <C-/> for help).

@kevinhwang91 it would be good to add such hint to README.

It's not necessary to add this hint because this issue is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants