Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition exposes already serialized "fields" #310

Open
2 tasks
kettanaito opened this issue Oct 23, 2018 · 0 comments
Open
2 tasks

Condition exposes already serialized "fields" #310

kettanaito opened this issue Oct 23, 2018 · 0 comments
Labels
breaking-change Change leading to major release. bug good first issue Good for newcomers.
Milestone

Comments

@kettanaito
Copy link
Owner

Environment

  • react-advanaced-form: 1.4.x - 1.5.2

What

Current behavior

When accessing the fields argument of the Condition.props.when function, it refers to the serialized fields.

Expected behavior

Condition.props.when exposes a reference to the fields of a form, as in its state.

Why

/* Resolve the condition in order to render the children */
const serializedFields = fieldUtils.serializeFields(fields)

Todo

  • Check why it explicitly serializes the fields
  • Remove fields serialization in Condition.props.when
@kettanaito kettanaito added the bug label Oct 23, 2018
@kettanaito kettanaito added this to the Bugs milestone Oct 23, 2018
@kettanaito kettanaito added breaking-change Change leading to major release. good first issue Good for newcomers. labels Oct 24, 2018
@kettanaito kettanaito modified the milestones: Bugs, 2.0 Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change leading to major release. bug good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

1 participant