Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for configuration files and command-line arguments #157

Open
dhillondeep opened this issue Jun 11, 2020 · 2 comments
Open

Support for configuration files and command-line arguments #157

dhillondeep opened this issue Jun 11, 2020 · 2 comments

Comments

@dhillondeep
Copy link

After looking at this project briefly, I see that there are many environment variables that the user can set. Viper makes configurations a breeze and also provides many great features out of the box such a using configuration files along with environment variables. It makes a lot of sense to switch to viper. While using viper, you can also utilize Cobra which will make the cli great! I would love to know your thoughts on this?

@cainlevy
Copy link
Member

Configuration files and command line flags have been on my wishlist since launch! I think those formats provide much better opportunities for discovering and documenting options.

I find it hard to escape ENV vars in production, personally.

@dhillondeep
Copy link
Author

viper can pretty much provide all that without taking any functionality away. A user could choose to provide values by env, config files or some hybrid approach. This helps in allowing customization based on the environment being used. I will look at codebase in more detail and see if it is not too much work and maybe I can create a PR for you to review!

@cainlevy cainlevy changed the title Use viper and cobra Support for configuration files and command-line arguments Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants