Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier APIs went async as of Prettier 3.0.0 #586

Open
steveluscher opened this issue Aug 23, 2023 · 0 comments · May be fixed by #588
Open

Prettier APIs went async as of Prettier 3.0.0 #586

steveluscher opened this issue Aug 23, 2023 · 0 comments · May be fixed by #588

Comments

@steveluscher
Copy link

Version 1.0.0 no longer works with Prettier >=3.0.0. All of the Prettier APIs went async. See https://github.com/prettier/prettier/blob/008b371e3ed64d31b85f10b6b3b67d3c32f175b6/changelog_unreleased/api/12574.md
This was referenced Aug 23, 2023
Open
Open
Closed
@steveluscher steveluscher mentioned this issue Mar 22, 2024
Merged
steveluscher added a commit to solana-labs/solana-web3.js that referenced this issue Mar 22, 2024
@steveluscher
Patch jest-runner-prettier to work with Prettier 3 (#2363)
5908de2 
# Summary

I completely forgot about keplersj/jest-runner-prettier#586 and this has been broken for a while.

# Test Plan

This is why I love `pnpm`

```shell
pnpm patch jest-runner-prettier
# add the awaits everywhere
pnpm patch-commit '/tmp/67d6a1a8e116289cd91a5e6eeb4f413d'
```

Break formatting in a file. `pnpm test:prettier`. Finally it registers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@steveluscher