Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode theme with nuance #29

Open
backseats opened this issue Oct 10, 2023 · 5 comments
Open

Vscode theme with nuance #29

backseats opened this issue Oct 10, 2023 · 5 comments

Comments

@backseats
Copy link

image

It would be great to use the light and dark tones provided in the theme for some more nuance similar to how Eppz! does it

I can add this later but wanted to throw it out if anyone wanted to get started on it

@Railly
Copy link
Contributor

Railly commented Oct 10, 2023

I agree with your point. When I was developing the theme, sticking to a consistent set of token color guidelines was difficult.

I've already got an algorithm that maps keywords based on token abbreviation (tx, tx-2, ui, etc), but I could create a similar one for mapping over constants, keywords, strings, and so on. Even my own theme could benefit from it, so it's a win-win.

I can create a new repo only focused on flexoki nuances, based on color rules (such Eppzz! image) to be easily customizable.

What do you think @kepano?

Options are:

  • New isolated repo based on clear token color guidelines, based on how Eppzz! do. If so, who gets the ownership?
  • Continue updating my repo with flexoki variants, as well as yours in this repo.
  • No action, no variants, just one single variation.

@backseats
Copy link
Author

backseats commented Oct 10, 2023 via email

@kepano
Copy link
Owner

kepano commented Oct 10, 2023

I like this idea. I think it makes sense. I have been working on my port for Sublime Text and was running into similar issues.

As @backseats just mentioned this will require me too add more color variations if we want to use opacity relationships — for the reasons explained in the Flexoki documentation. The muted/faint versions of the colors will not be derived using opacity, instead they will be fainter but still opaque shades of colors that are more saturated.

I think the token guidelines should be in this repo. I am open minded about where the generator code should be located. It would be neat if it can work for multiple syntax highlighters (e.g. VSCode, Sublime Text, PrismJS, etc), but that might be too ambitious.

@Railly
Copy link
Contributor

Railly commented Oct 11, 2023

I've just seen the generator folder. I'll be experimenting for a while on my own, then I'll come up with updates.

@Railly
Copy link
Contributor

Railly commented Oct 14, 2023

Hey, new updates here. @kepano

I've launched a new repo with 11 generators at the moment. I've replicated One Hunter Theme and Flexoki variants with it. There is an extensive README there, if you have any questions, you can leave it here. =)

https://github.com/Railly/tinte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants