Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated ERD's are very small since mermaid.js 10.0.2 upgrade #199

Open
Notalifeform opened this issue Apr 11, 2023 · 7 comments
Open

Generated ERD's are very small since mermaid.js 10.0.2 upgrade #199

Notalifeform opened this issue Apr 11, 2023 · 7 comments

Comments

@Notalifeform
Copy link

Hi,

OS: Linux bda6bb6910c4 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 GNU/Linux
Node version: v18.13.0

We upgraded to prisma-erd-generator 1.5.4 and now see that the generated ERD's are very small.
I see similar behaviour in the commit below. So I suspect that is the culprit?

2a6f2cb

image

@keonik
Copy link
Owner

keonik commented May 3, 2023

This has to be related to upgrading mermaid-cli. Here are a list of the options we can pass in to configure the mermaid cli for generating this erd

@keonik
Copy link
Owner

keonik commented May 3, 2023

I'm not sure if you can set the screen size or the min size but you can control the useMaxWidth which sets the width based on the browser screen size in puppeteer. If you set useMaxWidth: false it likely will be a scrollable svg that is huge. Let me know if you find another option in there to adjust this.

@francismanansala
Copy link

@keonik I think there's an issue with mermaid with a recent update, or at least with how it's being used. The relationships between tables show 2 lines:

image

@keonik
Copy link
Owner

keonik commented Jul 11, 2023

I'm going to make a change that reverts it back to the mermaid cli's puppeteer config setup found here https://github.com/mermaid-js/mermaid-cli/blob/9cd061ab77c3372bd4600721bac708967b1eec66/puppeteer-config.json#L3

@keonik
Copy link
Owner

keonik commented Jul 11, 2023

If the issue persists this may be an issue mermaid should have in their list.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.10.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants