Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedTuple Chord #25

Open
pylang opened this issue May 3, 2019 · 3 comments
Open

NamedTuple Chord #25

pylang opened this issue May 3, 2019 · 3 comments

Comments

@pylang
Copy link

pylang commented May 3, 2019

First off - great, fun library.

Your example of the C-chord in some tuning:

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 0, 0, 3, 3, 3)

It was not clear which tuning this was, but modifying your example to standard tuning, the C-chord could be:

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 3, 2, 0, 1, 0)

or is the orientation reversed?

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 1, 0, 2, 3, 0)

You can see the uncertainty in both tuning and orientation. I think returning a namedtuple would clear up these confusions:

>>> print(c_chord.fingering(fretboard=fretboard))
Fingering('E'=0, 'A'=3, 'D'=2, 'G'=0, 'B'=1, 'e'=0)
@pylang
Copy link
Author

pylang commented Mar 23, 2020

This was @kennethreitz's project. What happened?

@bisguzar
Copy link

bisguzar commented Mar 24, 2020

Hi @pylang ,Kenneth just moved all of his projects to volunteer developers. The new maintainer of this project is @Zelgius

@kennethreitz
Copy link
Owner

This is a good idea! Sorry that I'm just seeing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants