Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greasemonkey compatibility #23

Open
1 of 2 tasks
kellnerd opened this issue Apr 27, 2022 · 2 comments
Open
1 of 2 tasks

Greasemonkey compatibility #23

kellnerd opened this issue Apr 27, 2022 · 2 comments
Labels
compatibility MBS, browser and userscript manager compatibility

Comments

@kellnerd
Copy link
Owner

kellnerd commented Apr 27, 2022 •
edited

The voice actor userscript does not work with GM because it requires access to the MB global. Also, the script still contains a few jQuery references which had also broken the punctuation userscript in GM.

I should replace all remaining usages of jQuery and create a utility function to access MB and check all existing scripts again to see if they are working with GM then.

  • Replace jQuery with native DOM utilities
  • Provide save access to MB and other global MBS variables (GM context)
@kellnerd kellnerd added the compatibility MBS, browser and userscript manager compatibility label Apr 27, 2022
@kellnerd
Copy link
Owner Author

kellnerd commented Jul 2, 2022

No more jQuery in any of my userscripts as of today 🎉

@kellnerd kellnerd pinned this issue Aug 12, 2022
@kellnerd
Copy link
Owner Author

This link from #33 (comment) might still be relevant here:

I should finally look into Sharing objects with page scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility MBS, browser and userscript manager compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kellnerd