Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to open DIP in new page should also affect AIP and Representation levels #1530

Open
luis100 opened this issue May 22, 2020 · 0 comments
Assignees

Comments

@luis100
Copy link
Member

luis100 commented May 22, 2020

Currently, there is an option in configuration to open a DIP in a new page:

##########################################################################
# Show DIP with URL with iframe settings
##########################################################################
ui.dip.externalURL.showEmbedded = true

But this only affects the disseminations slider. When opening a DIP in the disseminations card on the AIP or Representation level, we are sent to the embedded DIP page.

This is due to the common logic not following the same logic as the disseminations slider, ignoring the option to open a DIP in a new page.

But, opening a DIP in a new page is necessary when a DIP refers to an external URL that requires CAS authentication and iframe logins are disallowed.

Change common logic to behave the same way as the disseminations slider. The dissemination slider may then rely in the common logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants