Qt 6 upgrade #7774

c4rlo · 2022-04-03T10:49:46Z

Summary

Qt 6 was released in Dec 2020. We should ultimately port KeePassXC to it from Qt 5. I'd be happy to help out with this.

Details

Before completely switching to Qt 6, we should introduce an opt-in build mode for it.

Before upgrading to Qt 6, make sure that your Qt 5 application is updated to Qt 5.15. The latest Qt 5 version has the least amount of changes when porting to Qt 6.

Currently, when building KeePassXC with -DWITH_DEV_BUILD=ON, there are a lot of warnings about usage of deprecated Qt features. For example:

src/cli/keepassxc-cli.cpp:236:71: warning: ‘QTextStream& QTextStreamFunctions::endl(QTextStream&)’ is deprecated: Use Qt::endl [-Wdeprecated-declarations]
  236 |         err << QObject::tr("Invalid command %1.").arg(commandName) << endl;
      |                                                                       ^~~~

However, Qt::endl is only available from Qt 5.14.

INSTALL.md currently lists "Qt 5 (>= 5.9.5)" as a requirement.

Question: Should we increase our minimum Qt 5 version requirement, to make porting to Qt 6 easier? Or would the maintainers prefer to keep the current minimum requirement? If the latter, then adding Qt 6 support would involve a few more #if QT_VERSION >= ... checks.

The text was updated successfully, but these errors were encountered:

droidmonkey · 2022-04-03T10:58:31Z

Moving to qt6 is easy for Mac and windows.... almost impossible on Linux right now. At least it would require a lot more work. We want to go to Qt6, but there is really no reason to do that right now.

c4rlo · 2022-04-03T12:58:14Z

What makes it so hard on Linux?

If it's opt-in as I suggested (e.g. behind -DWITH_QT6=ON), that should let Linux distro packagers upgrade when they are ready.

I'm also still curious about how feasible it would be to raise the minimum Qt 5 version.

droidmonkey · 2022-04-03T13:03:43Z

Omg no build flag, that would be a testing nightmare. The qt minimum version aligns with the oldest supported Ubuntu release. Qt6 has very low availability on Linux, only Ubuntu Jammy has it in the package repository at this time.

hifi · 2022-04-04T04:52:47Z

This is a list of the current status as of April 2022 of some relevant distribution channels.

The Good

Debian 12 (bookworm) Qt 6.2.2 (unreleased as of Apr 2022)
Ubuntu 22.04 LTS Qt 6.2.2 (release in Apr 2022)
Fedora 34/35/36/Rawhide Qt 6.2.3
Arch Linux Qt 6.2.4
openSUSE Tumbleweed Qt 6.2.4
NetBSD CURRENT Qt 6.2.2
OpenBSD 7.0/CURRENT Qt 6.0.4

The Bad

These are unlikely to get a backport of Qt 6 and we can't realistically wait this long. We should just make sure the Flatpak and AppImage run on these.

Debian 11 (bullseye), relevant until ~2026
Ubuntu 18.04 LTS, relevant until Apr 2028
Ubuntu 20.04 LTS, relevant until Apr 2030
CentOS 8 Stream, relevant until May 2024 (KeePassXC in EPEL8)

The Ugly

Relevant distribution channels that don't have Qt 6 yet.

FreeBSD - not in ports yet for some reason, this shouldn't be a blocker for us as it's on them
CentOS 9 Stream - not released yet but doesn't look like it'll have it, Flatpak/AppImage it is
Gentoo - not in main repository yet, there's one in Qt testing: Qt 6.2.4

Polynomial-C · 2022-04-06T08:20:20Z

The Good

* Gentoo **[Qt 6.2.4](https://github.com/gentoo/qt/tree/master/dev-qt/qtbase)**

Unfortunately this is not Gentoo's main package repository you were pointing to but a separate package repository mainly exisiting for qt testing.
Gentoo's main package repository (the one which the average user installs packages from) still is at qt-5.12.3

hifi · 2022-04-06T09:42:34Z

Ah, my bad. I'll move it, thanks for pointing that out!

c4rlo · 2022-04-10T21:03:56Z

@droidmonkey wrote:

The qt minimum version aligns with the oldest supported Ubuntu release.

That would be Ubuntu 18.04 (LTS): it has Qt 5.9.5. However, it also only has Botan 2.4.0, less than the required version (2.11.0).

Ubuntu 20.04 (the next LTS) has Qt 5.12.8 and Botan 2.12.1, so it's fine (and I've just confirmed keepassxc builds there).

Similarly, the oldest Fedora version that has a sufficiently recent Botan is Fedora 31; it has Botan 2.11.0 and Qt 5.13.2.

So assuming we are happy keeping the Botan 2.11 requirement, it would seem to make sense to:

Officially drop support for Ubuntu 18.04 (as it's already effectively unsupported due to Botan).
Potentially bump the minimum required Qt version to something like 5.12.

Any thoughts from the maintainers?

droidmonkey · 2022-04-10T21:07:04Z

We support 18.04 through our ppa. It's for easier to provide the right version of Botan than the right version of qt5 through a ppa.

c4rlo · 2022-04-10T22:11:26Z

I see – you've got libbotan-kpxc-2-12 in that repo. Makes sense. Although, aren't the Snap packages sufficient there?

droidmonkey · 2022-04-10T22:44:51Z

Snaps are built... differently.

c4rlo · 2022-04-11T07:05:34Z

What I meant was that since Ubuntu 18.04 users can already get KeePassXC from the Snap store (and as an AppImage), perhaps it could make sense to eventually remove the PPA and hence support for Ubuntu 18.04. This should allow us increase the minimum required Qt version.

I don't feel very strongly about it though.

droidmonkey · 2022-04-11T10:18:10Z

I'm in favor of that, at least freeze 18.04 to 2.7.x if necessary

yonas · 2022-09-09T20:11:10Z

@hifi FYI: Qt6 was added to FreeBSD on Aug 22.

droidmonkey · 2022-09-09T21:06:36Z

@phoerious I think we should make the leap in 2.8.0

ya-isakov · 2023-01-06T19:42:36Z

@hifi Gentoo has 6.4.{0,2} in main repo, although still "masked" - https://packages.gentoo.org/packages/dev-qt/qtbase

jNullj · 2023-02-11T11:05:35Z

qt 5 LTS will EOL very soon about 3 months.

Polynomial-C · 2023-02-11T13:15:26Z

qt 5 LTS will EOL very soon about 3 months.

I'd not be too much concerned about this. AFAIK, KDE-people already maintain qt-5.15.x for quite a while and as long as there's no kde-6 available, they will continue to add (security) fixes to qt-5.15.x.

varjolintu · 2023-12-02T15:00:29Z

Some relevant links that helped my compile KeePassXC with Qt 6.6.0:
https://doc.qt.io/qt-6/qtcore-changes-qt6.html
https://doc.qt.io/qt-6/extras-changes-qt6.html
https://doc.qt.io/qt-6/gui-changes-qt6.html#native-clipboard-integration
https://doc.qt.io/qt-6/qtcore5-index.html

orsonteodoro · 2024-02-03T04:26:07Z

I want to make a pull request so I can move on to porting other qt6 packages.

I have three versions of the patch.

For 2.7.6 [for stable] with NSL: https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-admin/keepassxc/files/keepassxc-2.7.6-qt6-support.patch
For live/develop with NSL: https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-admin/keepassxc/files/keepassxc-442d65a-qt6-support.patch
For live/develop without NSL (ready to send): https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-admin/keepassxc/files/keepassxc-eb89279-qt6-support-v2.patch

NSL (New Suffix List) is O(1) lookup, PSL [Public Suffix List from qtbase network] is O(log n) lookup with no difference in orders of magnitude. NSL is GPL-3 since it uses Wikipedia data but less TLD coverage.

The last one is ready to send.

The Test results can be found in in the two sections
NSL: https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-admin/keepassxc/keepassxc-9999.ebuild#L351
PSL: https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-admin/keepassxc/keepassxc-9999.ebuild#L444

The qt6 support currently requires Qt 6.6.1. I can refine the patch so that the minimum is more accurate for each API change.

If your okay with the pull request, then give the okay. Other criticism or code review is welcomed.

droidmonkey · 2024-02-03T04:31:03Z

@varjolintu already did the port for us, just needs to be put in a pr. https://github.com/varjolintu/keepassxc/tree/qt6

orsonteodoro · 2024-02-03T04:32:14Z

Okay. I will move on. Next time close it or rename the title.

pg83 · 2024-02-05T18:15:02Z

@droidmonkey As I can see, @orsonteodoro patch have freedesktop's org.freedesktop.secrets support. And @varjolintu patch does not.

BTW, entirely not cool situation.

varjolintu · 2024-02-05T18:24:56Z

@droidmonkey As I can see, @orsonteodoro patch have freedesktop's org.freedesktop.secrets support. And @varjolintu patch does not.

BTW, entirely not cool situation.

As you can see, this PR is still just a draft. It's not nearly finished.

pg83 · 2024-02-05T18:27:44Z

As you can see, this PR is still just a draft. It's not nearly finished.

That is why @orsonteodoro patch is strictly better.

varjolintu · 2024-02-05T18:39:19Z

As you can see, this PR is still just a draft. It's not nearly finished.

That is why @orsonteodoro patch is strictly better.

I cannot see any Passkeys related changes or tests in that patch. But seems there are a couple of things that are missing from my PR.

droidmonkey · 2024-02-05T18:47:50Z

@droidmonkey As I can see, @orsonteodoro patch have freedesktop's org.freedesktop.secrets support. And @varjolintu patch does not.

BTW, entirely not cool situation.

"Not cool"? I don't understand this. I simply stated that we already put some work into this matter.

Throwing links to patches on GitHub is really not helpful. Just open a pull request. That kicks off continuous integration testing and also bounds discussion of code specific changes to the PR and not the issue.

In general, I recommend discussing code changes like PSL vs NSL before doing any work at all.

JohnLGalt · 2024-02-05T22:43:19Z

To be fair, he did ask if it was OK to do a pull request:

If your okay with the pull request, then give the okay. Other criticism or code review is welcomed.

I think he misunderstood that you were basically saying yes.

varjolintu · 2024-02-06T09:17:41Z

Now that we have a PR, please comment any recommendations, fixes and other suggestions there instead of this thread, thanks. If the previous patch has some important improvements, those are gladly welcome.

c4rlo added the new feature label Apr 3, 2022

c4rlo mentioned this issue Apr 3, 2022

Fix all Qt 5.15 deprecation warnings #7783

Open

madebr mentioned this issue Apr 15, 2022

Pasting text into any field temporarily hangs the GUI + doesn't work #7902

Closed

droidmonkey added refactor EPIC and removed new feature labels Apr 20, 2022

Okeanos mentioned this issue Jul 31, 2022

cmake: add new macOS default location for QT discovery #8321

Merged

droidmonkey added this to the v2.8.0 milestone Sep 9, 2022

droidmonkey assigned droidmonkey and phoerious Sep 9, 2022

Gert-dev mentioned this issue Mar 13, 2023

KeePassXC does not show in Alt+Tab under GNOME Wayland until StartupNotify times out #6423

Closed

varjolintu linked a pull request Feb 4, 2024 that will close this issue

WIP: Qt6 transition #10267

Draft

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qt 6 upgrade #7774

Qt 6 upgrade #7774

c4rlo commented Apr 3, 2022

droidmonkey commented Apr 3, 2022 •

edited

c4rlo commented Apr 3, 2022 •

edited

droidmonkey commented Apr 3, 2022

hifi commented Apr 4, 2022 •

edited

Polynomial-C commented Apr 6, 2022

hifi commented Apr 6, 2022

c4rlo commented Apr 10, 2022 •

edited

droidmonkey commented Apr 10, 2022

c4rlo commented Apr 10, 2022

droidmonkey commented Apr 10, 2022

c4rlo commented Apr 11, 2022 •

edited

droidmonkey commented Apr 11, 2022

yonas commented Sep 9, 2022

droidmonkey commented Sep 9, 2022

ya-isakov commented Jan 6, 2023 •

edited

jNullj commented Feb 11, 2023

Polynomial-C commented Feb 11, 2023

varjolintu commented Dec 2, 2023

orsonteodoro commented Feb 3, 2024 •

edited

droidmonkey commented Feb 3, 2024 •

edited

orsonteodoro commented Feb 3, 2024

pg83 commented Feb 5, 2024

varjolintu commented Feb 5, 2024

pg83 commented Feb 5, 2024

varjolintu commented Feb 5, 2024 •

edited

droidmonkey commented Feb 5, 2024 •

edited

JohnLGalt commented Feb 5, 2024

varjolintu commented Feb 6, 2024

Qt 6 upgrade #7774

Qt 6 upgrade #7774

Comments

c4rlo commented Apr 3, 2022

Summary

Details

droidmonkey commented Apr 3, 2022 • edited

c4rlo commented Apr 3, 2022 • edited

droidmonkey commented Apr 3, 2022

hifi commented Apr 4, 2022 • edited

Polynomial-C commented Apr 6, 2022

hifi commented Apr 6, 2022

c4rlo commented Apr 10, 2022 • edited

droidmonkey commented Apr 10, 2022

c4rlo commented Apr 10, 2022

droidmonkey commented Apr 10, 2022

c4rlo commented Apr 11, 2022 • edited

droidmonkey commented Apr 11, 2022

yonas commented Sep 9, 2022

droidmonkey commented Sep 9, 2022

ya-isakov commented Jan 6, 2023 • edited

jNullj commented Feb 11, 2023

Polynomial-C commented Feb 11, 2023

varjolintu commented Dec 2, 2023

orsonteodoro commented Feb 3, 2024 • edited

droidmonkey commented Feb 3, 2024 • edited

orsonteodoro commented Feb 3, 2024

pg83 commented Feb 5, 2024

varjolintu commented Feb 5, 2024

pg83 commented Feb 5, 2024

varjolintu commented Feb 5, 2024 • edited

droidmonkey commented Feb 5, 2024 • edited

JohnLGalt commented Feb 5, 2024

varjolintu commented Feb 6, 2024

droidmonkey commented Apr 3, 2022 •

edited

c4rlo commented Apr 3, 2022 •

edited

hifi commented Apr 4, 2022 •

edited

c4rlo commented Apr 10, 2022 •

edited

c4rlo commented Apr 11, 2022 •

edited

ya-isakov commented Jan 6, 2023 •

edited

orsonteodoro commented Feb 3, 2024 •

edited

droidmonkey commented Feb 3, 2024 •

edited

varjolintu commented Feb 5, 2024 •

edited

droidmonkey commented Feb 5, 2024 •

edited