Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort advanced attribute list using locale aware sort #6175

Open
pigsflew opened this issue Feb 24, 2021 · 0 comments · May be fixed by #10091
Open

Sort advanced attribute list using locale aware sort #6175

pigsflew opened this issue Feb 24, 2021 · 0 comments · May be fixed by #10091
Labels
Milestone

Comments

@pigsflew
Copy link

pigsflew commented Feb 24, 2021

Overview

Additional Attributes are sorted by string ascii values, resulting in 10 coming before 2.

This results in strange behavior like the KP2A URL fields in the Browser integration tab being ordered oddly. When adding a 10th Additional URL, the new line will appear after the 1st entry and before the 2nd, not at the end of the list as you'd expect.

Example of the new KP2A_URL_# fields sorted badly

Steps to Reproduce

  1. Create 10 "Additional URLs" on an entry.
  2. Note that the 10th is added before the 2nd entry in the list.
  3. Flip to the Advanced tab and see why.

Expected Behavior

10 should appear at the end of the list.

Actual Behavior

10 appears after 1 and before 2.

Context

Note that this also happens in Windows and should happen on every platform.

KeePassXC - Version 2.6.4
Revision: 34a78f0
Distribution: Flatpak

Qt 5.15.2
Debugging mode is disabled.

Operating system: KDE Flatpak runtime (System: Ubuntu 20.04.2 LTS)
CPU architecture: x86_64
Kernel: linux 5.8.0-43-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:

  • libgcrypt 1.8.7

Desktop Env: Gnome
Windowing System: X11

@pigsflew pigsflew added the bug label Feb 24, 2021
@droidmonkey droidmonkey changed the title Sort lists lexicographically (alphanum) rather than ascii Sort advanced attribute list using locale aware sort Jun 16, 2021
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
@phoerious phoerious modified the milestones: v2.7.2, v2.8.0 Oct 17, 2022
marco-langer added a commit to marco-langer/keepassxc that referenced this issue Dec 10, 2023
Advanced attributes are sorted using locale aware sort.

Fixes keepassxreboot#6175
marco-langer added a commit to marco-langer/keepassxc that referenced this issue Dec 10, 2023
Advanced attributes are sorted using locale aware sort.

Fixes keepassxreboot#6175
marco-langer added a commit to marco-langer/keepassxc that referenced this issue Dec 10, 2023
Sort advanced attributes list using locale aware sort.

Fixes keepassxreboot#6175
marco-langer added a commit to marco-langer/keepassxc that referenced this issue Dec 10, 2023
Sort advanced attribute list using locale aware sort.

Fixes keepassxreboot#6175
@marco-langer marco-langer linked a pull request Dec 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants