Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if the unit of CoP is mm in grf.mot #130

Open
TheOne-1 opened this issue Mar 26, 2023 · 1 comment
Open

Error if the unit of CoP is mm in grf.mot #130

TheOne-1 opened this issue Mar 26, 2023 · 1 comment

Comments

@TheOne-1
Copy link
Collaborator

// Add 20cm to each side, to be very conservative
s_t padding = 0.20;
minX -= padding;
maxX += padding;
minZ -= padding;
maxZ += padding;

Close this issue if I'm wrong but my understanding of DynamicFitter is that it can adapt to .mot files with different CoP units (e.g., mm or m). However, I encountered "Marking trial 0, timestep xxx as probably missing GRF, due to contact heuristic" warning by using mm as CoP unit, probably because the above "padding" is in m.

@nickbianco
Copy link
Collaborator

@TheOne-1 I believe COP information is converted to meters before this step, although after checking OpenSimParser::loadGRF, I wasn't able to confirm this.

@keenon, do you know if we convert to meters somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants