Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

achieve reproducible build: Remove wildcard in AssemblyVersion #145

Open
tenzap opened this issue Mar 26, 2024 · 2 comments
Open

achieve reproducible build: Remove wildcard in AssemblyVersion #145

tenzap opened this issue Mar 26, 2024 · 2 comments

Comments

@tenzap
Copy link

tenzap commented Mar 26, 2024

In order for every build and rebuild of the same source code are reproducible (same output) could you please apply the change of this patch?

To achieve reproducible build, remove the wildcard for the
Revision of the AssemblyVersion
.
The wildcard for the revision corresponds to "The default revision number is
the number of seconds since midnight local time (without taking into account
time zone adjustments for daylight saving time), divided by 2."
.
See: https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assemblyversionattribute?redirectedfrom=MSDN&view=netframework-4.8#remarks
.
See also: dotnet/roslyn#39354

--- a/KeePassRPC/Properties/AssemblyInfo.cs
+++ b/KeePassRPC/Properties/AssemblyInfo.cs
@@ -18,5 +18,5 @@
 [assembly: Guid("89631AAE-8DE6-4593-8DAB-AB28490A490A")]
 
 // Assembly version information
-[assembly: AssemblyVersion("2.0.48.*")]
+[assembly: AssemblyVersion("2.0.48.0")]
 [assembly: AssemblyFileVersion("1.16.0.0")] // also change PluginVersion in KeePassRPCExt.cs!
@luckyrat
Copy link
Member

I am following the PLGX format requirements here - "Assembly Version: Should be set to the recommended KeePass version (i.e. the KeePass version your plugin is built for)." - however it appears that recommendation has been changed a long time ago without me spotting it in the release notes (I think either 2.17 or 2.18) and we should now set it to our own plugin version. Still, the PLGX sample plugin includes the * so I wouldn't want to make a change without either confirmation from Dominik that a fixed revision number will load, or some extended beta testing.

Is this the only remaining change needed to make the build 100% reproducible? If so, I'm happy to test it out but probably after the v2.0 release.

@tenzap
Copy link
Author

tenzap commented Apr 15, 2024

Is this the only remaining change needed to make the build 100% reproducible?

It looks like so.

(For all the dll you build for keepassrcp, but not for the PGLX, see https://sourceforge.net/p/keepass/feature-requests/2872/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants