Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Docker images to ghcr.io/kedacore/http-add-on/* #567

Open
tomkerkhove opened this issue Jan 9, 2023 · 4 comments
Open

Move Docker images to ghcr.io/kedacore/http-add-on/* #567

tomkerkhove opened this issue Jan 9, 2023 · 4 comments
Assignees
Labels
proposal stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@tomkerkhove
Copy link
Member

tomkerkhove commented Jan 9, 2023

As of today, our images are structured as following:
image

Which you can pull through:

docker pull ghcr.io/kedacore/http-add-on-interceptor

However, I'm wondering if we should change them to the following before v1.0:

- ghcr.io/kedacore/http-add-on-interceptor
+ ghcr.io/kedacore/http-add-on/interceptor
- ghcr.io/kedacore/http-add-on-operator
+ ghcr.io/kedacore/http-add-on/operator
- ghcr.io/kedacore/http-add-on-scaler
+ ghcr.io/kedacore/http-add-on/scaler
@JorTurFer
Copy link
Member

I'm not 100% sure if GH supports the extra segment (I think so), but dockerhub doesn't support it, Contributors who are working in the repo and need to publish their images can't do IMAGE_REGISTRY=docker.io IMAGE_REPO=jorturfer make docker-publish, they would need to override the full qualified name for each image.
It's not a problem because it's supported, but maybe it's a side effect we haven't considered yet

@tomkerkhove
Copy link
Member Author

Yes, you can definitely do this in GHCR.

I personally think it's worth the change to provide some structure but it's not a must. @kedacore/keda-maintainers @kedacore/keda-http-maintainers ?

@JorTurFer
Copy link
Member

JorTurFer commented Jan 13, 2023

We can do it if there isn't any objection, my only concern is about developing experience, but I can think about how to make it easier. Next week I'll take a look

@stale
Copy link

stale bot commented Mar 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 14, 2023
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Mar 14, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Status: To Triage
Development

No branches or pull requests

2 participants