Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use StaticString for #line #function and #file in LoggerStore.storeMessage? #237

Open
Scvairy opened this issue Feb 13, 2024 · 1 comment

Comments

@Scvairy
Copy link

Scvairy commented Feb 13, 2024

It is a common thing to use StaticString for known at compile-time strings, it reduces overhead of regular modifiable Strings.

Why is it decided to use String instead of StaticString?

@Scvairy
Copy link
Author

Scvairy commented Feb 13, 2024

I'm not sure if we will gain any benefits in performance, but I suggest to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant