Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Wire in dev certificate for mounts in kcp start #3065

Open
mjudeikis opened this issue Dec 22, 2023 · 2 comments
Open

bug: Wire in dev certificate for mounts in kcp start #3065

mjudeikis opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mjudeikis
Copy link
Contributor

Describe the bug

This is to track https://github.com/kcp-dev/kcp/pull/3057/files#diff-8788f7c7e1c9b5d5b7df0e3a320164e8cc298040cebea5acaeb4ccd9f85ee854R157

As follow-up:
When running kcp start we generate a development certificate for api-server. It is being reused for all rest/API trust in the local kcp instance. We need to reuse the same certificate when running virtual workspaces in dev.

When making calls we should use the same CA as our dev certificate. Its callers responsibility to use this certificate when developing virtual-workspaces. Need to document this use case in developers docs too.,

Steps To Reproduce

See PR

Expected Behaviour

Use TLS

Additional Context

No response

@mjudeikis mjudeikis added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2023
@mjudeikis mjudeikis self-assigned this Dec 22, 2023
@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2024
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants