Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add a "kubectl kcp workspace delete" command #2924

Open
1 task done
manoelmarques opened this issue Mar 27, 2023 · 6 comments
Open
1 task done

feature: Add a "kubectl kcp workspace delete" command #2924

manoelmarques opened this issue Mar 27, 2023 · 6 comments
Labels
area/kubectl Everything around the client experience. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@manoelmarques
Copy link

manoelmarques commented Mar 27, 2023

Feature Description

Even though one can delete a workspace with kubectl delete workspace myworkspace, I believe there should be also a kubectl kcp workspace delete myworkspace command since there is already a create command.

Proposed Solution

I already have the code implementing it, just need to create formal unit tests now.

In case this issue is approved, I could immediately create a WIP PR with the implementation while I work on the unit tests.

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@manoelmarques manoelmarques added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2023
@manoelmarques manoelmarques changed the title feature: Add a "kubectl workspace delete" command feature: Add a "kubectl kcp workspace delete" command Mar 28, 2023
@ncdc
Copy link
Member

ncdc commented Apr 4, 2023

We used to have one, because it required extra logic beyond what kubectl delete workspace does. Once we removed the need for that extra logic (it was in #778), we removed the subcommand, favoring having the users use kubectl delete.

I do, however, understand the lack of symmetry between kubectl ws create and kubectl delete workspace... @sttts I believe you did the PR to remove kubectl ws delete ... have any revised thoughts at this time? cc @stevekuznetsov @davidfestal

@embik
Copy link
Member

embik commented Jul 6, 2023

A possible alternative to explore is looking into a custom kubectl create subcommand, which might be available by now.

@embik embik added the area/kubectl Everything around the client experience. label Jul 6, 2023
@sttts
Copy link
Member

sttts commented Jul 7, 2023

A possible alternative to explore is looking into a custom kubectl create subcommand, which might be available by now.

Background: in the past kubectl did not call out on kubectl create foo to kubectl-create-foo, only on top-level commands. Afaik this has changed like few months ago. So you can now place a custom create func and kubectl will use it.

@embik
Copy link
Member

embik commented Jan 8, 2024

A possible alternative to explore is looking into a custom kubectl create subcommand, which might be available by now.

Background: in the past kubectl did not call out on kubectl create foo to kubectl-create-foo, only on top-level commands. Afaik this has changed like few months ago. So you can now place a custom create func and kubectl will use it.

FYI, this is still not possible according to documentation.

@sttts
Copy link
Member

sttts commented Jan 9, 2024

Works with kubectl 1.29.0.

Bildschirmfoto 2024-01-09 um 21 45 42

@embik
Copy link
Member

embik commented Jan 10, 2024

Ohhh so upstream documentation is outdated. Interesting, thank you for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubectl Everything around the client experience. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants