Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c.CacheDynamicClient uses default QPS/burst settings and gets throttled #2743

Open
ncdc opened this issue Feb 2, 2023 · 9 comments
Open
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ncdc
Copy link
Member

ncdc commented Feb 2, 2023

We should choose a better default (or disable QPS entirely), and possibly make it configurable.

@ncdc
Copy link
Member Author

ncdc commented Feb 2, 2023

FYI @p0lyn0mial @stevekuznetsov @sttts

@p0lyn0mial
Copy link
Contributor

I don't think we should disable QPS now. The cache-server is not protected by Priority and Fairness.
More shards will but more load on the cache-server.
It looks like client-side rate limiting is our only option for now.

Not sure what it would take to enable APF on the server.
Now, I'm not even sure we use max-requests-inflight in the cache-server.

@ncdc
Copy link
Member Author

ncdc commented Feb 3, 2023

Fair... but let's go with something with more than the default settings?

@p0lyn0mial
Copy link
Contributor

Fair... but let's go with something with more than the default settings?

+1

Should I prep something or leave it to you?

@ncdc
Copy link
Member Author

ncdc commented Feb 3, 2023

Up to you 😀

@p0lyn0mial
Copy link
Contributor

OK, I'll prepare a PR. Thanks for reporting!

@p0lyn0mial
Copy link
Contributor

/assign @p0lyn0mial

@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Next
Development

No branches or pull requests

3 participants