Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching controller-runtime & kcp #20

Open
fgiloux opened this issue Jul 28, 2022 · 4 comments
Open

Matching controller-runtime & kcp #20

fgiloux opened this issue Jul 28, 2022 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@fgiloux
Copy link

fgiloux commented Jul 28, 2022

We need an easy way to match a controller-runtime version with a kcp release.
Looking at go.mod is cumbersome.
Ideally we would either have a branch or tag of kcp version of controller-runtime that matches a kcp release branch/tag.

@stevekuznetsov
Copy link

After e.g. APIExport virtual workspace is stable (ish), the version requirements will be very loose, right?

@ncdc
Copy link
Member

ncdc commented Aug 17, 2022

It's mostly about lining up kcp-dev/apimachinery and kcp-dev/logicalcluster. apimachinery is still a bit of a moving target (at times), but logicalcluster can just be go get github.com/kcp-dev/logicalcluster/v2@latest.

@kcp-ci-bot
Copy link

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2024
@kcp-ci-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants