Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhancement the schema attribute completing in composite schema, list, dict and union types. #1097

Open
Peefy opened this issue Mar 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request lsp

Comments

@Peefy
Copy link
Contributor

Peefy commented Mar 1, 2024

Due to the advanced resolver and schema config scope owner https://github.com/kcl-lang/kcl/blob/main/kclvm/sema/src/advanced_resolver/node.rs#L1132. It does not cover all situations. For example

schema Name:
    n: str

schema Config:
    names: [Name]

Config{
    names: [{<cursor>}]
} 

The completion item of <cursor> is n instead of names.

More background and examples can be seen in this PR #1096

@Peefy Peefy added enhancement New feature or request lsp labels Mar 1, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Mar 3, 2024
@Peefy Peefy modified the milestones: v0.8.0 Release, v0.9.0 Release Mar 7, 2024
@He1pa
Copy link
Contributor

He1pa commented May 21, 2024

2
image

@He1pa
Copy link
Contributor

He1pa commented May 21, 2024

3 #1343
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lsp
Projects
None yet
Development

No branches or pull requests

2 participants