Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Shell completion support #4

Open
2 of 4 tasks
woodruffw opened this issue Jul 30, 2017 · 9 comments
Open
2 of 4 tasks

Shell completion support #4

woodruffw opened this issue Jul 30, 2017 · 9 comments

Comments

@woodruffw
Copy link
Member

woodruffw commented Jul 30, 2017

Currently, KBSecret provides (mediocre) bash completion support. It'd be nice to make this support more complete, and add support for some other shells.

An incomplete list (which will get edited/checked off as necessary):

  • Bash (rewrite)
  • Zsh
  • Fish
  • Ksh

See #56 for how future effort might be dedicated to this.

@guille
Copy link
Contributor

guille commented Oct 1, 2017

I'm currently working on the zsh completion

@guille
Copy link
Contributor

guille commented Oct 1, 2017

The zsh completion file is pretty much done. All that's left is adding some descriptions to the commands. I figured I'd ask here for ideas since I'm not too familiar with the codebase. So if you could drop me a line for the following commands I'll add it and submit the PR.

  • conf
  • dump-fields
  • env
  • generator
  • generators
  • list
  • login
  • new-session
  • new
  • pass
  • raw-edit
  • rm-session
  • rm
  • sessions
  • stash-file
  • todo
  • types

Example screenie:
zsh completion

@woodruffw
Copy link
Member Author

Awesome, thanks @guille!

You can find descriptions for those commands under their respective manpages. For example, for kbsecret conf, check out https://kbsecret.github.io/man/0.9.2/kbsecret-conf.1.html. Let me know if anything needs clarification.

@guille
Copy link
Contributor

guille commented Oct 1, 2017

My bad, totally missed the manpages. Just submitted #23

@woodruffw
Copy link
Member Author

My bad, totally missed the manpages.

Not a problem 😄

I'll review the PR in a bit.

@woodruffw woodruffw modified the milestones: 1.0, 1.1 Jan 17, 2018
@woodruffw
Copy link
Member Author

Postponing until 1.1.

@jpninanjohn
Copy link

jpninanjohn commented Oct 2, 2019

Hi
Is this still open for bash completions?

@woodruffw
Copy link
Member Author

Hi @jpninanjohn! Yes, this is still open. There are currently bash completions in the repo but we'd greatly appreciate a rewrite.

@jpninanjohn
Copy link

Thank you. Will look into this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants