Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Shadow DOM by default #119

Open
kazzkiq opened this issue Jun 4, 2020 · 1 comment
Open

Enable Shadow DOM by default #119

kazzkiq opened this issue Jun 4, 2020 · 1 comment
Labels
enhancement
Milestone
v2

Comments

@kazzkiq
Copy link
Owner

kazzkiq commented Jun 4, 2020

CodeFlask depends on specific CSS in order to keep sync between <textarea>, <pre> and <code> blocks.

More than often, users face issues were a project already has imperative CSS code that styles those elements, and this leads to misconfigurations in CodeFlask editor instances (aka. Page CSS leaks into CodeFlask elements).

A good way to prevent this is using Shadow DOM whenever creating a CodeFlask instance, so there is no risk of CSS leakage in or out the editor.
@kazzkiq kazzkiq added this to the v2 milestone Jun 4, 2020
@kazzkiq kazzkiq mentioned this issue Jun 5, 2020
Open
@kazzkiq
Copy link
Owner Author

kazzkiq commented Jun 5, 2020

Related Issues that would be fixed by this approach: #109, #106, #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@kazzkiq