Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version dependency on labelled in tests #92

Open
MichaelChirico opened this issue Mar 3, 2022 · 0 comments
Open

Version dependency on labelled in tests #92

MichaelChirico opened this issue Mar 3, 2022 · 0 comments

Comments

@MichaelChirico
Copy link

This line induces behavior in labelled that's not present in v1.0.0:

tableone/tests/testthat/test-CreateTableOne.R

Line 284 in b02ef39

labelled::val_label(pbc_labeled$age, 1) <- "youngest"

The issue didn't cause an error in the current CRAN version of labelled, 2.9.0. I didn't check when exactly the labelled behavior changed.

Two fixes:

  1. add skip_if_not_installed("labelled", "2.9.0") to that test
  2. add a version dependency on labelled, e.g. very conservatively labelled (>= 2.9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelChirico