Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sulfur into VESIcal #171

Open
simonwmatthews opened this issue Sep 7, 2022 · 1 comment
Open

Add sulfur into VESIcal #171

simonwmatthews opened this issue Sep 7, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@simonwmatthews
Copy link
Collaborator

I think a really useful advance would be to incorporate sulfur models into VESIcal. This is a bit more complex than adding new H2O or CO2 models, so will need quite a bit of attention. I also know there is quite a bit of interest in this from the community and so I thought it would be good to flag it as a future feature we are thinking about.

The steps to doing this are:

  1. Code up a sulfur solubility model (e.g., https://doi.org/10.1016/j.gca.2022.08.032).
  2. Code up a sulfur fugacity model (ideally incorporating H2O and CO2, if such a model exists).
  3. Modify the underlying VESIcal methods to cope with a third volatile phase. This could be a real nightmare, or might be surprisingly straightforward. VESIcal was constructed with an expansion like this in mind, but some of the numerical methods may have been optimised specifically for two components.

I am unlikely to have time to do much work on this myself, but I am very happy to help someone else do this!

@simonwmatthews simonwmatthews added the enhancement New feature or request label Sep 7, 2022
@simonwmatthews simonwmatthews self-assigned this Sep 7, 2022
@simonwmatthews simonwmatthews added the help wanted Extra attention is needed label Sep 7, 2022
@kaylai
Copy link
Owner

kaylai commented Mar 19, 2024

Commenting here as I am thinking about this a lot right now. I am working to go through the code for Sulfur_X and planning to add this into VESIcal. Eventually, I would like the addition of a handful of sulfur models to be a key component of "VESIcal 2.0", which would be a new publication with a whole host of features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants