Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibration checks to density and viscosity models #167

Open
kaylai opened this issue Apr 21, 2022 · 1 comment
Open

Add calibration checks to density and viscosity models #167

kaylai opened this issue Apr 21, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kaylai
Copy link
Owner

kaylai commented Apr 21, 2022

@simonwmatthews I've added the density and viscosity code in and will push that to pip in v1.1.0 soon. Since there is only one model for density and one for viscosity, I did not use a model_classes file like we did for the volatile solubility models. I'm unsure of the best way to add calibration checks for these models. Would you mind taking a look?

@kaylai kaylai added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2022
@simonwmatthews
Copy link
Collaborator

I think the best way to do it would be to have all the calibration check code sitting directly in the ThermoCalculate classes, i.e., the equivalent code to models.magmasat.check_calibration_range() could go directly into thermo.thermo_calculate_classes.calculate_liquid_density.check_calibration_range(). Or have I missed something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants