Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShishkinaIdealMixing incorrectly reports it can't find a saturation pressure #156

Open
simonwmatthews opened this issue Jan 5, 2022 · 0 comments
Open

ShishkinaIdealMixing incorrectly reports it can't find a saturation pressure #156

simonwmatthews opened this issue Jan 5, 2022 · 0 comments
Assignees
@simonwmatthews
Labels
bug Something isn't working

Comments

@simonwmatthews
Copy link
Collaborator

When the H2O component is undersaturated in the Shishkina-mixed model, calculate_saturation_pressure reports that it couldn't find the saturation pressure. However, the result it reports is correct- it is the error that is erroneous. We just need to revise how the failure is detected and handled.
@simonwmatthews simonwmatthews added the bug Something isn't working label Jan 5, 2022
@simonwmatthews simonwmatthews self-assigned this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonwmatthews simonwmatthews

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonwmatthews