Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_model_names() does not return MagmaSat in list #154

Open
kaylai opened this issue Nov 17, 2021 · 0 comments
Open

get_model_names() does not return MagmaSat in list #154

kaylai opened this issue Nov 17, 2021 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kaylai
Copy link
Owner

kaylai commented Nov 17, 2021

There is maybe an internal reason for returning all models except MagmaSat for this function call, since MagmaSat is treated differently and separately from all other models. But, for the user, it is confusing that we don't return MagmaSat in the list of model names. Should be easy to track down and fix.

Note also that there are two functions: get_model_names() and get_models() that I think are unnecessary duplicates, so those should be cleaned up as well.

@kaylai kaylai added bug Something isn't working good first issue Good for newcomers labels Nov 17, 2021
@kaylai kaylai self-assigned this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant