Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Notebook changes: Never gives value for dixon degassing at 2wt% H2O #137

Open
PennyWieser opened this issue Mar 18, 2021 · 3 comments
Assignees

Comments

@PennyWieser
Copy link
Collaborator

Going through the testing notebooks using a version of VESical downloaded on 16th of March.

This returns an output:
my_sample2 = {'SiO2': 49,
'TiO2': 1.13,
'Al2O3': 15.86,
'Fe2O3': 0.929,
'FeO': 7.53,
'MgO': 10.05,
'CaO': 12.15,
'Na2O': 2.70,
'K2O': 0.31,
'H2O': 1.0,
'CO2': 0.05}
my_sample2 = v.Sample(my_sample2)
open_df_sample2 = v.calculate_degassing_path(sample=my_sample2, temperature=1200, model='Dixon', fractionate_vapor=1).result
#closed_df_sample2 = v.calculate_degassing_path(sample=my_sample2, temperature=1200, model='Dixon', fractionate_vapor=0).result

But If I change H2O = 2 when I define the sample, it never gives an output, but also doesn't return any error messages (E.g., Kernel keeps going forever).

@PennyWieser
Copy link
Collaborator Author

Just realized this is the same as #123 .. Those issues still exist...Waiting for Jackie to send a degassing path

@simonwmatthews
Copy link
Collaborator

How are you changing the composition? By complete duplication of the code?

@PennyWieser
Copy link
Collaborator Author

Yes, second code is exactly the same, just H2O=2 not 1 (have it in 2 scripts so it doesnt kill the other script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants