Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More models to add #124

Open
kaylai opened this issue Sep 3, 2020 · 5 comments
Open

More models to add #124

kaylai opened this issue Sep 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@kaylai
Copy link
Owner

kaylai commented Sep 3, 2020

A growing list of models that could be added to VESIcal:

  • Papale (2006), via translation of FORTRAN code
  • Duan (2014)
  • Zhang et al. (2007)
  • Moussallam et al (2015) for Foidites/Kimberlites (https://doi.org/10.1016/j.chemgeo.2014.11.017)
  • Allison et al. (2022) MafiCH
  • Burnham H2O model
  • Duan and Zhang (2006) EOS
  • Allabar et al. (2022) H2O solubility in peralkaline rhyolites
  • Silver, L., & Stolper, E. (1985). A thermodynamic model for hydrous silicate melts. The Journal of Geology, 93(2), 161-177. Essentially the rhyolite model behind VolatileCalc-rhyolite
  • MIMiC
@kaylai kaylai added the enhancement New feature or request label Sep 3, 2020
@kaylai kaylai added this to the Future Features milestone Sep 3, 2020
@PennyWieser
Copy link
Collaborator

PennyWieser commented Mar 18, 2021

Zhang et al. (2007) - I have this code up very poorly in python its just a function of cation fractions. Might be worth doing - In the Waters and Lange hygrometry paper, they calculate fractions wrong, so are off by *0.1-0.2 (sorry remmebered this wrong, off by 0.5- 1 wt% H2O relative to MagmaSat)
Happy to help when adding functions!

@kaylai
Copy link
Owner Author

kaylai commented Mar 20, 2021

WHOA. That's serious business. Myself and Gordon are both friends with Laura. Maybe worth going over this and letting her know!

Also, thanks! I've added Zhang et al (2007) to the list :)

@PennyWieser
Copy link
Collaborator

Yus, sorry, should have said, I worked it out when I asked for their spreadsheet. Sorry, i remembered wrong, its off by 0.15 relative to real zhang, but up to nearly 1wt% relative to MagmaSat. I've been chatting to her about seeing whether it changes the calibration or not to use MagmaSat instead (as Zhang is a very, very simple model)

@corinjorgenson
Copy link

Hi Kayla (and others) as I mentioned during your talk for the University of Geneva here is the paper for the Moussallam et al 2015 ( https://doi.org/10.1016/j.chemgeo.2014.11.017) model which is for low silica/transitional melts. It's really designed for high CO2 melts, so might not be what you guys are looking for but it's here if you are curious!

And thanks again - this is such a cool program!

Moussallam et al 2015.pdf

@kaylai
Copy link
Owner Author

kaylai commented May 5, 2021

Hi Kayla (and others) as I mentioned during your talk for the University of Geneva here is the paper for the Moussallam et al 2015 ( https://doi.org/10.1016/j.chemgeo.2014.11.017) model which is for low silica/transitional melts. It's really designed for high CO2 melts, so might not be what you guys are looking for but it's here if you are curious!

And thanks again - this is such a cool program!

Moussallam et al 2015.pdf

Thank you! It has been added to the list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants