Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the way parameter structures are expressed in C++. #3

Open
2 tasks
eirrgang opened this issue Oct 17, 2022 · 0 comments
Open
2 tasks

Clean up the way parameter structures are expressed in C++. #3

eirrgang opened this issue Oct 17, 2022 · 0 comments
Assignees
@eirrgang

Comments

@eirrgang
Copy link
Collaborator

eirrgang commented Oct 17, 2022 •
edited

I need to incorporate the additional templating demonstrated in kassonlab/sample_restraint@master...eirrgang:sample_restraint:simplify#diff-7ec9c1207a050c91428018658d3b6a4af3b025918db18273ea2427bfb158a9fb and kassonlab/sample_restraint@master...eirrgang:sample_restraint:simplify#diff-45219af25be5df641fc50fd2bba96a91f284648254213183e907bea9704455b5 before establishing a more automated "express once" style for the parameter structures.

Originally posted by @eirrgang in #2 (comment)

  • Use more expressive templates for declaring (and documenting) input, output, and state variables for the pluggable restraints.
  • Use the C++ parameter structs, directly, to implement the brer.plugin_configs classes so that
    • we know the allowed and required parameters unambiguously
    • we don't duplicate documentation
    • we don't hide the application of default values (in the C++ headers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirrgang eirrgang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eirrgang