Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder doesn't work due to old branch names #63

Open
paulmaunders opened this issue Dec 31, 2020 · 3 comments
Open

Binder doesn't work due to old branch names #63

paulmaunders opened this issue Dec 31, 2020 · 3 comments

Comments

@paulmaunders
Copy link

paulmaunders commented Dec 31, 2020

I used generate_badge() to add a binder badge to my repo, however when clicking it binder gave the following error:

Could not resolve ref for gh:paulmaunders/coronavirus-graphs/master. Double check your URL. GitHub recently changed default branches from "master"to "main". Did you mean the "main" branch?

Updating the badge link to main helped, but then I encountered another error:

Resolving github.com (github.com)... 140.82.114.4
Connecting to github.com (github.com)|140.82.114.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2020-12-31 17:43:32 ERROR 404: Not Found.

So it looks like the references to master in the DockerFile need updating too.

@paulmaunders
Copy link
Author

I've just realised there is a pull request to allow setting of branch names: #61

This is a good idea, but I suggest the default branch name is updated to main as well.

@karthik
Copy link
Owner

karthik commented Jan 11, 2021

Thanks, I'll merge that shortly.

@paezha
Copy link

paezha commented Aug 5, 2021

Thank you for this awesome package! I am new to binder and could set my repository up with minimal pain. That said, I had the same issue with the badge making reference to the master branch. I edited it to main and now the link works, but this might throw off novice users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants