Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bugs in the data loading functions #321

Open
PeterZhizhin opened this issue May 1, 2024 · 0 comments
Open

Possible bugs in the data loading functions #321

PeterZhizhin opened this issue May 1, 2024 · 0 comments

Comments

@PeterZhizhin
Copy link
Contributor

First, we read B*T+1 tokens, but advance the iterator by B*T tokens instead.

Then, there is this if statement:

    if (loader->current_position + (loader->num_processes * B * T + 1) * sizeof(int) > loader->file_size)

Possibly, we should remove the loader->num_processes multiplication here.

We need to verify that this is the way these functions should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant