Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Images from local file paths not displaying correctly if contains special characters like % or # #11

Open
karolzak opened this issue Aug 12, 2020 · 2 comments
Open

[Bug] Images from local file paths not displaying correctly if contains special characters like % or # #11

karolzak opened this issue Aug 12, 2020 · 2 comments
Labels
bug Something isn't working known issue wontfix This will not be worked on
Projects
Release 1.1 Continuous improvements

Comments

@karolzak
Copy link
Owner

Example filename that would not display correctly:
SHAUN%20OF%20THE%20DEAD%20Bloopers%20#t=18.jpg

image
@karolzak karolzak added the bug Something isn't working label Aug 12, 2020
@karolzak karolzak added this to To do in Release 1.1 via automation Aug 12, 2020
@karolzak karolzak mentioned this issue Aug 13, 2020
Closed
@karolzak
Copy link
Owner Author

After a short research it seems like it's only % and # characters that are causing issues because of how URLs are being encoded when browser is rendering HTML code. So far it seems like it's not possible to fix it in any way from IPyPlot module level.
Best effort would be just display a warning msg for each local image file URL containing either # or % characters.

@karolzak karolzak added the wontfix This will not be worked on label Aug 13, 2020
@karolzak
Copy link
Owner Author

One more option to consider would be to automatically convert local URLs with faulty characters to PIL.Image objects or something similar.

@karolzak karolzak moved this from To do to In progress in Release 1.1 Aug 13, 2020
@karolzak karolzak moved this from In progress to To do in Release 1.1 Sep 22, 2020
@karolzak karolzak moved this from To do to Done in Release 1.1 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working known issue wontfix This will not be worked on
Projects
Continuous improvements
To do
Release 1.1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karolzak