Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada tutorial description needs correction. #486

Open
zhzhuang-zju opened this issue Oct 8, 2023 · 5 comments · May be fixed by #614
Open

Karmada tutorial description needs correction. #486

zhzhuang-zju opened this issue Oct 8, 2023 · 5 comments · May be fixed by #614
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zhzhuang-zju
Copy link
Contributor

zhzhuang-zju commented Oct 8, 2023

What would you like to be added:

Why is this needed:
This description will lead to the misunderstanding that nginx application related resource are all propagated to member2 . In fact, these resources are also propagated to member1.

As you see, you shall find `nginx` application related resource are all propagated to `member2` cluster,
which means the higher priority `PropagationPolicy` does work.

@zhzhuang-zju zhzhuang-zju added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 8, 2023
@shivansh-bhatnagar18
Copy link

@zhzhuang-zju @RainbowMango Can I assign this issue to myself so I can work on this

@zhzhuang-zju
Copy link
Contributor Author

Sure, go ahead~
You can think about how to change it first, and then synchronize to its older version. Looking forward to your feedback

@shivansh-bhatnagar18
Copy link

shivansh-bhatnagar18 commented May 24, 2024

@zhzhuang-zju I think that in the verification part of Applying Higher Priority PropagationPolicy, we can add verification commands for both member1 and member2 clusters to clarify that the nginx application-related resources are propagated to both member1 and member2. The updated documentation will look something like this.
Screenshot from 2024-05-24 18-23-37
Looking forward to your insights on this

@zhzhuang-zju
Copy link
Contributor Author

@zhzhuang-zju I think that in the verification part of Applying Higher Priority PropagationPolicy, we can add verification commands for both member1 and member2 clusters to clarify that the nginx application-related resources are propagated to both member1 and member2.

Good idea~
To echo the theme, how about change the description to:

You should see the `nginx` application related resources originally in `member1` are also propagated to `member2`, completing the migration of resources.

@shivansh-bhatnagar18
Copy link

@zhzhuang-zju This explains better. I think we are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants