Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how-to added #317

Closed
wants to merge 5 commits into from
Closed

how-to added #317

wants to merge 5 commits into from

Conversation

rgrupesh
Copy link
Member

@rgrupesh rgrupesh commented Feb 27, 2023 •
edited

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Enhances documentation

Which issue(s) this PR fixes:
Fixes #109

Special notes for your reviewer:
Should we include additional information about contributing, such as coding style and instructions for setting up locally, on the same page as this one or on a different page?
@RainbowMango

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 27, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
RainbowMango
RainbowMango reviewed Feb 28, 2023
View reviewed changes
docs/contributor/contribute-docs.md Outdated Show resolved Hide resolved
docs/contributor/contribute-docs.md Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2023
@rgrupesh rgrupesh requested review from RainbowMango and removed request for Poor12 and Tingtal February 28, 2023 05:02
@RainbowMango
Copy link
Member

Hi @rgrupesh merge commit is not allowed, please rebase.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 28, 2023
@RainbowMango
Copy link
Member

Please help squash commits, then will be all set, thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member

/hold
@rgrupesh do you need help?

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@rgrupesh
Copy link
Member Author

rgrupesh commented Mar 1, 2023

/hold @rgrupesh do you need help?

@RainbowMango I squashed my first commit to this branch with the previous commit of the main branch, and left newer commit how-to removed and markdown synatx link added as it is.

@rgrupesh
Copy link
Member Author

rgrupesh commented Mar 3, 2023

/hold @rgrupesh do you need help?

@RainbowMango I squashed my first commit to this branch with the previous commit of the main branch, and left newer commit how-to removed and markdown synatx link added as it is.

@RainbowMango

@RainbowMango
Copy link
Member

I don't think this PR should contain other guys' commit. Please rebase your branch and push again.

Arhell and others added 5 commits March 4, 2023 14:23
@Arhell @rgrupesh
update dependencies
33d034d 
Signed-off-by: Arhell <arhell333@gmail.com>
@XiShanYongYe-Chang @rgrupesh
set release v1.5 document
ed685a7 
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang @rgrupesh
change v1.x.0 to v1.x
2b04acb 
Signed-off-by: changzhen <changzhen5@huawei.com>
@fengshunli @rgrupesh
updaete blog title
4496455 
Signed-off-by: fsl <1171313930@qq.com>

how-to added

Signed-off-by: rgrupesh <rupeshgelal9@gmail.com>
@rgrupesh
how-to removed and markdown synatx link added
3c5b15b 
Signed-off-by: rgrupesh <rupeshgelal9@gmail.com>
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2023
@rgrupesh rgrupesh closed this Mar 4, 2023
@rgrupesh rgrupesh deleted the con-docs branch March 4, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create CONTRIBUTING.md file
6 participants
@rgrupesh @RainbowMango @karmada-bot @Arhell @XiShanYongYe-Chang @fengshunli