Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support auto bump container images with dependabot. #4932

Merged
merged 1 commit into from May 23, 2024
Merged

chore: support auto bump container images with dependabot. #4932

merged 1 commit into from May 23, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented May 12, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

support auto bump container images with dependabot, but I'm not sure whether we should treat release branch like this, it's means we need to update release branch from this file when a new release is out.

option2 is only auto bump container image for master and cherry pick the PR of dependabot to release branch if need.

Which issue(s) this PR fixes:
Fixes #4908

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 12, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (3fc8ef5) to head (26db029).
Report is 70 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4932      +/-   ##
==========================================
+ Coverage   53.14%   53.34%   +0.19%     
==========================================
  Files         251      252       +1     
  Lines       20415    20482      +67     
==========================================
+ Hits        10850    10926      +76     
+ Misses       8852     8835      -17     
- Partials      713      721       +8
Flag Coverage Δ
unittests 53.34% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

Amazing!

I'm not sure whether we should treat release branch like this, it's means we need to update release branch from this file when a new release is out.

I think letting Dependabot handle these things for both master and release branches would be better.

Two more things we should consider about:

  1. we need to update the configuration(.github/dependabot.yml) after a new release and remove the one that is out of maintenance.
  2. The PR sent by Dependabot doesn't use the PR template, how to set the release notes?

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented May 15, 2024 •
edited

  1. We can update it when needed together with

    karmada/.github/workflows/ci-schedule-compatibility.yaml

    Line 20 in c7ca958

    karmada-version: [ release-1.7, release-1.8, release-1.9 ]
    , so it won't be forgotten

  2. apparently I forgot about this, dependabot can't cover this. We may need other things to do this. like: edit the PR description if PR author is dependabot[bot] and PR have the label docker
    2.1) write the javascript with github action actions/github-script
    2.2) wirte the code in karmada with go repo and run it with github action.
    2.3) write a prow plugin.

For simplicity I would choose option 2.2, other idea is welcome .

@RainbowMango
Copy link
Member

We can update it when needed together with

OK.

apparently I forgot about this, dependabot can't cover this. We may need other things to do this. like: edit the PR description if PR author is dependabot[bot] and PR have the label docker
2.1) write the javascript with github action actions/github-script
2.2) wirte the code in karmada with go repo and run it with github action.
2.3) write a prow plugin.

For simplicity I would choose option 2.2, other idea is welcome .

Will see, those solutions sound a little bit heavy.

@zhzhuang-zju zhzhuang-zju mentioned this pull request May 23, 2024
Closed
4 tasks
RainbowMango
RainbowMango reviewed May 23, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@liangyuanpeng
chore: support auto bump container images with dependabot.
26db029 
Signed-off-by: Lan Liang <gcslyp@gmail.com>
RainbowMango
RainbowMango approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@karmada-bot karmada-bot merged commit 33350b2 into karmada-io:master May 23, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the auto_bump_docker branch May 23, 2024 06:39
This was referenced May 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@jwcesign jwcesign Awaiting requested review from jwcesign

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CVE-2024-2511] openssl: Unbounded memory growth with session handling in TLSv1.3
4 participants
@liangyuanpeng @codecov-commenter @RainbowMango @karmada-bot