Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Align generation and observedGeneration fields by reflectstatus and aggregatestatus operation #4870

Open
20 tasks
yike21 opened this issue Apr 25, 2024 · 6 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@yike21
Copy link
Member

yike21 commented Apr 25, 2024

What would you like to be added:
There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

  • Native resource
  • Thirdparty resource
    • GroupVersion: apps.kruise.io/v1alpha1
      Kind:
      • CloneSet
      • DaemonSet
    • GroupVersion: apps.kruise.io/v1beta1
      Kind:
      • StatefulSet
    • GroupVersion: helm.toolkit.fluxcd.io/v2beta1
      Kind:
      • HelmRelease
    • GroupVersion: kustomize.toolkit.fluxcd.io/v1
      Kind:
      • Kustomization
    • GroupVersion: source.toolkit.fluxcd.io/v1
      Kind:
      • GitRepository
    • GroupVersion: source.toolkit.fluxcd.io/v1beta2
      Kind:
      • Bucket
      • HelmChart
      • HelmRepository
      • OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

@yike21 yike21 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2024
@karmada-bot
Copy link
Collaborator

@yike21:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:
There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

  • native resource
  • GroupVersion: apps/v1
    kind:
  • Thirdparty resource
  • GroupVersion: apps.kruise.io/v1alpha1
    kind:
    • CloneSet
    • DaemonSet
  • GroupVersion: apps.kruise.io/v1beta1
    kind:
    • StatefulSet
  • GroupVersion: helm.toolkit.fluxcd.io/v2beta1
    kind:
    • HelmRelease
  • GroupVersion: kustomize.toolkit.fluxcd.io/v1
    kind:
    • Kustomization
  • GroupVersion: source.toolkit.fluxcd.io/v1
    kind:
    • GitRepository
  • GroupVersion: source.toolkit.fluxcd.io/v1beta2
    kind:
    • Bucket
    • HelmChart
    • HelmRepository
    • OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karmada-bot karmada-bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 25, 2024
@liangyuanpeng
Copy link
Contributor

I want to try it for StatefulSet

@yike21
Copy link
Member Author

yike21 commented Apr 25, 2024

I want to try it for StatefulSet

Thanks a lot~

@XiShanYongYe-Chang
Copy link
Member

@yike21 Good Job!

@whitewindmills
Copy link
Member

I wanna pick up DaemonSet, thanks.

@yike21
Copy link
Member Author

yike21 commented Apr 26, 2024

I wanna pick up DaemonSet, thanks.

ok, thanks a lot~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

5 participants