Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command shortcuts are not configurable in Firefox #7

Open
karlicoss opened this issue Jan 28, 2019 · 7 comments
Open

Command shortcuts are not configurable in Firefox #7

karlicoss opened this issue Jan 28, 2019 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@karlicoss
Copy link
Owner

karlicoss commented Jan 28, 2019

Apparently it was broken at some point? Anyway, seems like the fix is there but will only be released in March 2019. So, in the meantime, you can capture via clicking the extension button. I guess I could also just bind something different for Firefox, instead of default Ctrl-Shift-C and Ctrl-Shift-Y, which happen to mean something in Firefox by default.
I'm open for suggestions, since have no idea what common shortcuts are already occupied by the most common Firefox extensions!

@karlicoss karlicoss changed the title Extension shortcuts are not configurable in Firefox Command shortcuts are not configurable in Firefox Jan 28, 2019
@karlicoss
Copy link
Owner Author

Latest Firefox (67) finally allows configuring the shortcuts, so this is not a problem anymore! However, you can't override default keybindings, so perhaps making Ctrl-Alt-C and Ctrl-Alt-Y as default makes more sense..

@karlicoss karlicoss added enhancement New feature or request help wanted Extra attention is needed labels Oct 5, 2019
@petr-tik
Copy link

petr-tik commented Dec 13, 2019

Thanks for the awesome extension. A friend of mine has been banging on about how amazing org-mode is and I wanted to start using it from my firefox locally.

+1 on this issue and a further feature request.

I would like to select some text on the page, then press Ctrl-Alt-Y and prepopulate the comments section in the grasp note with the selected text.

Even better if I can use SurfingKeys to select some text, instead of using a mouse (come as close as possible to emacs - mouseless).

Not sure how easy it is to make 2 extensions play friendly though. Otherwise, I can use SurfingKeys to select and copy text to clipboard and then ideally use a key binding to pre-populate a grasp note with text from the clipboard.

Is it possible to configure such key bindings? If so, please explain how and add to readme, so others can benefit too!

Thanks again

@petr-tik
Copy link

Even better if I can use SurfingKeys to select some text, instead of using a mouse (come as close as possible to emacs - mouseless).

Not sure how easy it is to make 2 extensions play friendly though. Otherwise, I can use SurfingKeys to select and copy text to clipboard and then ideally use a key binding to pre-populate a grasp note with text from the clipboard.

This already works!

I would like to select some text on the page, then press Ctrl-Alt-Y and prepopulate the comments section in the grasp note with the selected text.

This still doesn't - is that a use case that you are interested in at all and/or is it possible to implement?

@karlicoss
Copy link
Owner Author

@petr-tik so, the selected text gets captured already (see 'selection' here ), the comment box populates 'comment' filed.
Unless you want to edit the selection or interleave it with your comments?

@petr-tik
Copy link

You are right - it does.

I found one bug though. If I make several text selections on one page, press Ctrl-Alt-Y to capture them, the selections end up concatenated without a newline character.

If it's not too heavy duty, it would make sense to me to create a

#+BEGIN_QUOTE
#+END_QUOTE

block for every selection. I don't think interleaving my comments with selections/quotes is necessary, but I think it makes sense to save selections as quotes.

Can I do this with a different org-mode capture template or does it require changing the extension?

@karlicoss
Copy link
Owner Author

@petr-tik good catch! I've moved it in a separate issue.

@steady137
Copy link

steady137 commented Jun 3, 2022

Thanks @karlicoss for this extension. After finding it mentioned on reddit I've been a happy user for almost 20 minutes!

I had recently discovered Firefox's "unified" way to configure shortcuts for all extensions, including this one. Access is quaint: right-click an extension button (such as grasp) > Manage Extension > click the gear icon at top right "Tools for all add-ons" > select Manage Extension Shortcuts. Hopefully you find grasp with both of these:

  • Quick capture: url, title and selection
  • Capture page, with extra information

Cheers!

@petr-tik thanks for the SurfingKeys mouse-independence suggestion too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants