Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion on create_batches.py #93

Open
shenwei356 opened this issue Mar 5, 2024 · 1 comment
Open

Suggestion on create_batches.py #93

shenwei356 opened this issue Mar 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@shenwei356
Copy link

Hi Karel, create_batches.py works as expected, here are just some minor suggestions.

  1. In the help message, clustered_fastas.tsv is the input metafile containing file and species column, while its name is kind of misunderstood, I thought it was the output. How about meta_file.tsv.

  2. log output is inaccurate. 1932811 should be 1932812 after checking both the input data and output data.

     Loaded 1932811 genomes across 10357 species clusters
    
  3. Some instruction or notification might be added to tell users to delete the output directory before running this script, cause it does not complain if the output directory is not empty, which might bring some unexpected results.

@karel-brinda
Copy link
Owner

karel-brinda commented Mar 5, 2024

Great suggestions / observations! Thanks a lot!

@karel-brinda karel-brinda added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants