Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should delete the selected text if user type the new text with selected range. #2117

Open
andy840119 opened this issue Sep 5, 2023 · 1 comment
Open

Should delete the selected text if user type the new text with selected range. #2117

andy840119 opened this issue Sep 5, 2023 · 1 comment
Labels
Design New UI/UX design or style changed. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. LyricMaker Implement lyric maker part into karaoke ruleset.

Comments

@andy840119
Copy link
Member

image
Should delete the selected text if user type the new text with selected range.

Unlike #2116, it's more like "delete the text then re-add it". so if the ruby or time-tag with-in the selection range, they will be removed.
@andy840119 andy840119 added LyricMaker Implement lyric maker part into karaoke ruleset. Design New UI/UX design or style changed. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. labels Sep 5, 2023
@andy840119
Copy link
Member Author

andy840119 commented Sep 5, 2023 •
edited

Maybe add RemoveThanInsertText(int charGap, int count = 1, string text) in the ILyricTextChangeHandler i guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design New UI/UX design or style changed. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. LyricMaker Implement lyric maker part into karaoke ruleset.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119