Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version does not reflect minor releases #91

Open
pyousefi opened this issue May 28, 2017 · 0 comments · May be fixed by #106
Open

Version does not reflect minor releases #91

pyousefi opened this issue May 28, 2017 · 0 comments · May be fixed by #106

Comments

@pyousefi
Copy link

pyousefi commented May 28, 2017 •
edited

Current version 1.0.3 still shows 1.0.0
montmanu added a commit to montmanu/joe that referenced this issue May 8, 2020
@montmanu
update deps + minor formatting improvements, fixes, features
201056c 
deps
---------------

* support golang v1.13
* migrate to Go Modules
* replace github.com/codegangsta/cli with github.com/urfave/cli

formatting
---------------

* reformat using `go fmt`
* address `golint` warnings
* address `shellcheck` warnings

fixes
---------------

* update `version` const in `joe.go` to `1.0.3`
* add `./build` prefix to executable path in `tool.sh run`

features
---------------

* set executable path based on host environment in `tool.sh run`
* forward remaining arguments to `joe` in `tool.sh run`
* redirect output to `stderr` in `usage` function of `tool.sh`

fixes karan#91
closes karan#104
closes karan#100
@montmanu montmanu linked a pull request May 8, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update deps + minor formatting improvements, fixes, features montmanu/joe
1 participant
@pyousefi