Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a problem in index.html #18

Open
ivanpierre opened this issue Apr 4, 2016 · 3 comments
Open

Just a problem in index.html #18

ivanpierre opened this issue Apr 4, 2016 · 3 comments

Comments

@ivanpierre
Copy link

The goog.require() has not the namespace transformed in Javascript standard.
I have a go-bang.core instead of go_bang.core.
Change in the string makes the app working perfectly ;)
https://github.com/karad/lein_template_descjop/blob/master/resources/leiningen/new/descjop/reagent__app__index.html#L16
{{name}} should be changed by {{santitized}} ?

@karad
Copy link
Owner

karad commented Apr 10, 2016

Thank you for your advice. I fixed this problem. and add some new features!

@karad karad closed this as completed Apr 12, 2016
@ivanpierre
Copy link
Author

ivanpierre commented Apr 16, 2016

There's a similar problem but in the other direction when creating cljs namespace ;)
I discovered reviewing the code as it was accepted with the HTML code change :D

@karad karad reopened this Apr 17, 2016
@karad
Copy link
Owner

karad commented Apr 20, 2016

Thank you, so I want to know your project name when you couldn't run electron app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants